Add API for ARC(P-256) and deprecate ARC(P-384) #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjbeaumont
force-pushed
the
sb/arc-p256
branch
from
99b140d to
c58a33d
Compare
simonjbeaumont
force-pushed
the
sb/arc-p256
branch
from
c58a33d to
f3baa63
Compare
Contributor
Author
|
@Lukasa OK, CI is happy with this one now. |
Lukasa
reviewed
Jul 2, 2025
|
|
||
| // MARK: - P384 + ARC(P-384) | ||
| @available(iOS 16.0, macOS 13.0, watchOS 9.0, tvOS 16.0, macCatalyst 16.0, visionOS 2.0, *) | ||
| @available(*, deprecated, message: "ARC(P-384) has been removed from the IETF draft; use ARC(P-256) instead.") |
Contributor
There was a problem hiding this comment.
Does placing the deprecation here work, or does it need to go on the inner enum?
Contributor
Author
There was a problem hiding this comment.
Seems to be. If I add this to a test file:
func f() {
let _ = P384._ARCV1 // warning: '_ARCV1' is deprecated: ARC(P-384) has been removed from the IETF draft; use ARC(P-256) instead.
}
Lukasa
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The ARC IETF draft has been updated to now support P256 and drop support for P384.
Modifications
Result
P256._ARCV1, which provides an implementation of ARC(P-256).P384._ARCV1, which provides an implementation of ARC(P-256).