arc: Switch to using stored property for ciphersuite

simonjbeaumont · simonjbeaumont · commit c58a33d776b0 · 2025-07-01T18:28:51.000+01:00
diff --git a/Sources/_CryptoExtras/ARC/ARC+API.swift b/Sources/_CryptoExtras/ARC/ARC+API.swift
@@ -27,8 +27,7 @@ extension P256 {
         internal typealias Ciphersuite = ARC.Ciphersuite<H2G>
         fileprivate typealias Server = ARC.Server<H2G>
 
-        // TODO: ARC internals changed recently to use this a lot more——might benefit from being a stored property.
-        internal static var ciphersuite: Ciphersuite { Ciphersuite(H2G.self) }
+        internal static let ciphersuite = Ciphersuite(H2G.self)
     }
 }
 
@@ -408,8 +407,7 @@ extension P384 {
         internal typealias Ciphersuite = ARC.Ciphersuite<H2G>
         fileprivate typealias Server = ARC.Server<H2G>
 
-        // TODO: ARC internals changed recently to use this a lot more——might benefit from being a stored property.
-        internal static var ciphersuite: Ciphersuite { Ciphersuite(H2G.self) }
+        internal static let ciphersuite = Ciphersuite(H2G.self)
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -27,8 +27,7 @@ extension P256 {`
`27`	`27`	`internal typealias Ciphersuite = ARC.Ciphersuite<H2G>`
`28`	`28`	`fileprivate typealias Server = ARC.Server<H2G>`
`29`	`29`
`30`		`- // TODO: ARC internals changed recently to use this a lot more——might benefit from being a stored property.`
`31`		`- internal static var ciphersuite: Ciphersuite { Ciphersuite(H2G.self) }`
	`30`	`+ internal static let ciphersuite = Ciphersuite(H2G.self)`
`32`	`31`	`}`
`33`	`32`	`}`
`34`	`33`
`@@ -408,8 +407,7 @@ extension P384 {`
`408`	`407`	`internal typealias Ciphersuite = ARC.Ciphersuite<H2G>`
`409`	`408`	`fileprivate typealias Server = ARC.Server<H2G>`
`410`	`409`
`411`		`- // TODO: ARC internals changed recently to use this a lot more——might benefit from being a stored property.`
`412`		`- internal static var ciphersuite: Ciphersuite { Ciphersuite(H2G.self) }`
	`410`	`+ internal static let ciphersuite = Ciphersuite(H2G.self)`
`413`	`411`	`}`
`414`	`412`	`}`
`415`	`413`