containertool: Add basic ELF file type detection #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The container's architecture metadata field should match the architecture of the executable it contains. The plugin can't currently tell which architecture the SDK targets, but
containertool
can infer the architecture by reading the ELF headers.Modifications
containertool
to use the detected architecture unless overridden by command line flags or environment variables.Result
Adding ELF detection reduces the risk of building a mismatched container image, where the architecture of the packaged binary does not match the architecture of the underlying Linux distribution.
Test Plan
containertool
selects the correct base image architecture for different cross-compiled binariesFixes #49