Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix test target names with "ArgumentParser" #74

Closed

Conversation

elliottwilliams
Copy link
Contributor

@elliottwilliams elliottwilliams commented Mar 9, 2020

Similar to d8fb6bd and #18.

Prior to Swift 5.2, test target names need to be unique throughout the entire package graph. This change adds "SAP" "ArgumentParser" to each test target to avoid ambiguities.

Context: I'm trying to use swift-argument-parser in a package repo which also depends on Carthage, and they have a nested dependency with a UnitTests target. Since the argument parser is under active development and I assume I'm not the only one in this situation, I figured I would propose the change here.

Checklist

  • [n/a] I've added at least one test that validates that my change is working, if appropriate
  • [n/a] I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • [n/a] I've updated the documentation if necessary

@natecook1000
Copy link
Member

Thanks for getting this workaround ready, @elliottwilliams! Looking at all the names, we'd rather go with an ArgumentParser prefix for everything. Would you mind adopting that prefix, including renaming SAPTestHelpers?

@elliottwilliams elliottwilliams force-pushed the rename_testing_targets branch from 9356da0 to 7a9c440 Compare March 9, 2020 22:43
@elliottwilliams
Copy link
Contributor Author

@natecook1000 sure thing, updated!

@elliottwilliams elliottwilliams changed the title Prefix test targets with SAP Prefix test target names with "ArgumentParser" Mar 9, 2020
natecook1000 pushed a commit that referenced this pull request Mar 10, 2020
* Prefix testing and test helper targets with ArgumentParser

* Replace SAP with ArgumentParser in imports and CMakeLists
@natecook1000
Copy link
Member

Thanks, @elliottwilliams! Merged locally.

griffin-stewie pushed a commit to griffin-stewie/swift-argument-parser that referenced this pull request Mar 11, 2020
* Prefix testing and test helper targets with ArgumentParser

* Replace SAP with ArgumentParser in imports and CMakeLists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants