This repository was archived by the owner on Oct 17, 2021. It is now read-only.
Prefix target names with 'GraphViz' to avoid collisions #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target names must be globally unique, even once SE-0026 is fully implemented (see https://forums.swift.org/t/multiple-target-issue-with-spm/16696/4). The "Core" target added in #15 introduces a naming conflict with XcodeGen, and while I've proposed XcodeGen rename their "Core" target (yonaskolb/XcodeGen#1057) it probably makes sense to rename the target here as well, to avoid similar conflicts in the future.
The naming convention is obviously subject to bikeshedding – lmk if there's a different way you'd like to organize these :)
For examples of other packages that have had to do things like this, see apple/swift-argument-parser#74 and apple/swift-argument-parser@d8fb6bd