Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add a separate function for service startup validation #1038

Merged
merged 6 commits into from
Oct 4, 2024
Merged

feat: Add a separate function for service startup validation #1038

merged 6 commits into from
Oct 4, 2024
+158 −118

Conversation

mykola-mokhnach
Copy link
Contributor

Also sorted module-private methods and aligned service url parsing logic

KazuCocoa
KazuCocoa approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left process handling comment, otherwise lg entirely

appium/webdriver/appium_service.py Outdated Show resolved Hide resolved
@mykola-mokhnach mykola-mokhnach merged commit 90b9978 into appium:master Oct 4, 2024
10 checks passed
@mykola-mokhnach mykola-mokhnach deleted the service_upd branch October 4, 2024 15:36
@mykola-mokhnach mykola-mokhnach mentioned this pull request Oct 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KazuCocoa KazuCocoa KazuCocoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mykola-mokhnach @KazuCocoa