feat: add timeout for server stop as method param #1030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LykashevichAndrei
force-pushed
the
master
branch
from
bcfb6a8
to
e168586
Compare
|
I am not sure what you are trying to achieve by this PR. Active connections close timeout is currently hardcoded on the server side and won't be affected by the process timeout. |
|
at least for now i will not see error on test postconditions that appium server was not closed however this is a good catch and i will review appium server code and may be provide another PR to avoid this hardcode |
|
Please rename the PR to comply with the https://www.conventionalcommits.org/en/v1.0.0/ standard |
KazuCocoa
changed the title
KazuCocoa
reviewed
Oct 3, 2024
|
Closed in favour of #1038 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.