Skip to content

refactor!: Remove setElementValue helper #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2021
Merged

refactor!: Remove setElementValue helper #1577

merged 1 commit into from
Nov 1, 2021

Conversation

mykola-mokhnach
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach commented Nov 1, 2021 •
edited
Loading

Change list

The CanSetElementValue interface has been added as a part of #1555, however I can observe that sendKeys does exactly the same POST /value call, so there is no need for one more duplicated method for it. Thus, removing it as redundant.

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@mykola-mokhnach mykola-mokhnach merged commit de3ded4 into appium:master Nov 1, 2021
@mykola-mokhnach mykola-mokhnach deleted the rm_value branch November 1, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valfirst valfirst valfirst approved these changes

@SrinivasanTarget SrinivasanTarget SrinivasanTarget approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mykola-mokhnach @valfirst @SrinivasanTarget