Skip to content

refactor!: Remove setElementValue helper #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2021
Merged

refactor!: Remove setElementValue helper #1577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/main/java/io/appium/java_client/AppiumDriver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ public class AppiumDriver extends RemoteWebDriver implements
ComparesImages,
ExecutesDriverScript,
LogsEvents,
CanSetElementValue,
HasBrowserCheck,
HasSettings {

Expand Down
35 changes: 0 additions & 35 deletions src/main/java/io/appium/java_client/CanSetElementValue.java
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion src/test/java/io/appium/java_client/android/AndroidElementTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public class AndroidElementTest extends BaseAndroidTest {
driver.startActivity(activity);
WebElement editElement = driver
.findElement(AppiumBy.androidUIAutomator("resourceId(\"io.appium.android.apis:id/edit\")"));
driver.setElementValue((RemoteWebElement) editElement, value);
editElement.sendKeys(value);
assertEquals(value, editElement.getText());
}
}
3 changes: 1 addition & 2 deletions src/test/java/io/appium/java_client/ios/IOSElementTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
import org.junit.Test;
import org.junit.runners.MethodSorters;
import org.openqa.selenium.WebElement;
import org.openqa.selenium.remote.RemoteWebElement;
import org.openqa.selenium.support.ui.WebDriverWait;

import io.appium.java_client.AppiumBy;
Expand All @@ -33,7 +32,7 @@ public void setValueTest() {

WebElement slider = wait.until(
driver1 -> driver1.findElement(AppiumBy.className("XCUIElementTypeSlider")));
driver.setElementValue((RemoteWebElement) slider, "0%");
slider.sendKeys("0%");
assertEquals("0%", slider.getAttribute("value"));
}
}
5 changes: 2 additions & 3 deletions src/test/java/io/appium/java_client/pagefactory_tests/XCUITModeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
import org.junit.Test;
import org.junit.runners.MethodSorters;
import org.openqa.selenium.WebElement;
import org.openqa.selenium.remote.RemoteWebElement;
import org.openqa.selenium.support.PageFactory;

import java.util.List;
Expand Down Expand Up @@ -141,8 +140,8 @@ public class XCUITModeTest extends AppIOSTest {
}

@Test public void setValueTest() {
driver.setElementValue((RemoteWebElement) textField1, "2");
driver.setElementValue((RemoteWebElement) textField2, "4");
textField1.sendKeys("2");
textField2.sendKeys("4");
driver.hideKeyboard();
computeButton.click();
assertEquals("6", answer.getText());
Expand Down