Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove uuid dependency #1669

Merged
merged 3 commits into from
Sep 9, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/common/renderer/actions/Inspector.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import _ from 'lodash';
import {v4 as UUID} from 'uuid';

import {SAVED_FRAMEWORK, SET_SAVED_GESTURES} from '../../shared/setting-defs';
import {POINTER_TYPES} from '../constants/gestures';
Expand Down Expand Up @@ -982,7 +981,7 @@ export function saveGesture(params) {
continue;
}
// Adding a new gesture
param.id = UUID();
param.id = crypto.randomUUID();
param.date = Date.now();
savedGestures.push(param);
}
Expand Down
3 changes: 1 addition & 2 deletions app/common/renderer/actions/Session.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import {notification} from 'antd';
import axios from 'axios';
import {includes, isPlainObject, isUndefined, toPairs, union, values, without} from 'lodash';
import moment from 'moment';
import {v4 as UUID} from 'uuid';
import {Web2Driver} from 'web2driver';

import {
Expand Down Expand Up @@ -662,7 +661,7 @@ export function saveSession(server, serverType, caps, params) {

if (!uuid) {
// If it's a new session, add it to the list
uuid = UUID();
uuid = crypto.randomUUID();
let newSavedSession = {
date: Date.now(),
name,
Expand Down
2 changes: 1 addition & 1 deletion docs/quickstart/requirements.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Since the Inspector has two versions, [a desktop app and a web app](../overview.
requirements for these will differ.

- Web app
- Works in Chrome/Edge/Firefox, released September 2021 or later
- Works in Chrome/Edge/Firefox, released in 2022 or later
([Safari is not supported](../troubleshooting.md#browser-version-does-not-work-in-safari))
- Viewport size of at least **870 x 610** pixels is recommended
- Desktop app
Expand Down
13 changes: 0 additions & 13 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@
"//dependencies": {
"antd": "V5: significant rewrite required",
"bluebird": "Deprecated: recommended to replace with native promises",
"cheerio": "V1: requires Node 18",
"uuid": "V10: requires Node 16. Can also be replaced with crypto.randomUUID in Electron 14+"
"cheerio": "V1: requires Node 18"
},
"dependencies": {
"@reduxjs/toolkit": "2.2.7",
Expand All @@ -88,7 +87,6 @@
"react-icons": "5.3.0",
"react-redux": "9.1.2",
"react-router-dom": "6.26.1",
"uuid": "9.0.1",
"web2driver": "3.0.4",
"xpath": "0.0.34"
},
Expand Down
2 changes: 1 addition & 1 deletion renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"automerge": true
},
{
"matchPackageNames": ["antd", "cheerio", "eslint", "uuid"],
"matchPackageNames": ["antd", "cheerio", "eslint"],
"matchUpdateTypes": ["major"],
"enabled": false
},
Expand Down