Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove uuid dependency #1669

Merged
merged 3 commits into from
Sep 9, 2024
Merged

chore: remove uuid dependency #1669

merged 3 commits into from
Sep 9, 2024

Conversation

eglitise
Copy link
Collaborator

@eglitise eglitise commented Sep 9, 2024

The recent update to Electron 31 also bumped the embedded Chromium version, and one of its new features is the crypto.randomUUID() method (added in Electron 14 / Chromium 92). This method can directly replace the v4 UUID generated by uuid.
As crypto.randomUUID() is a relatively recent addition, the system requirement docs have also been updated.

I tested saving new sessions in both the app and browser, and didn't see any differences from the current implementation.

@github-actions github-actions bot added chore Internal changes not visible to the user dependencies Dependency updates, removals or additions documentation Improvements or additions to documentation labels Sep 9, 2024
@eglitise eglitise merged commit 1e7bdab into appium:main Sep 9, 2024
7 checks passed
@eglitise eglitise deleted the drop-uuid branch September 9, 2024 13:19
laib3 pushed a commit to laib3/appium-inspector that referenced this pull request Nov 16, 2024
* chore: remove uuid dependency

* chore: remove uuid from renovate blocklist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Internal changes not visible to the user dependencies Dependency updates, removals or additions documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants