-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes two unnecessary warn logs from the ResponseVisitor #6192
Conversation
✅ Docs Preview ReadyNo new or changed pages found. |
This comment has been minimized.
This comment has been minimized.
CI performance tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, maybe simplify the changeset a bit? It's perfect as a PR description but users don't/shouldn't know what a ResponseVisitor
is, so I'd just mention something along the lines that demand control no longer produces warnings when a subgraph did not return a value for a requested field.
When the ResponseVisitor attempts to match a JSON response to its corresponding query, it is possible that the subgraph did not return a requested field. In this case, the ResponseVisitor was creating a noisy warning log which can be run into quite frequently.
This removes those two logs since we will ignore the mismatch anyway, and demand control should not be responsible for policing the format of subgraph responses.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩