Remove unnecessary warn logs from ResponseVisitor (#6192)

apollographql · Oct 25, 2024 · 17d90eb · 17d90eb
1 parent 79b0aca
commit 17d90eb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/.changesets/fix_tninesling_remove_demand_control_warnings.md b/.changesets/fix_tninesling_remove_demand_control_warnings.md
@@ -0,0 +1,5 @@
+### Remove noisy demand control logs ([PR #6192](https://github.com/apollographql/router/pull/6192))
+
+Demand control no longer logs warnings when a subgraph response is missing a requested field.
+
+By [@tninesling](https://github.com/tninesling) in https://github.com/apollographql/router/pull/6192
diff --git a/apollo-router/src/graphql/visitor.rs b/apollo-router/src/graphql/visitor.rs
@@ -92,18 +92,11 @@ pub(crate) trait ResponseVisitor {
                             inner_field.as_ref(),
                             value,
                         );
-                    } else {
-                        tracing::warn!("The response did not include a field corresponding to query field {:?}", inner_field);
                     }
                 }
                 apollo_compiler::executable::Selection::FragmentSpread(fragment_spread) => {
                     if let Some(fragment) = fragment_spread.fragment_def(request) {
                         self.visit_selections(request, variables, &fragment.selection_set, fields);
-                    } else {
-                        tracing::warn!(
-                            "The fragment {} was not found in the query document.",
-                            fragment_spread.fragment_name
-                        );
                     }
                 }
                 apollo_compiler::executable::Selection::InlineFragment(inline_fragment) => {