Skip to content

Fix test failure with Node 18.20.3 #7898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fix test failure with Node 18.20.3 #7898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/four-dogs-brake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
10 changes: 6 additions & 4 deletions packages/server/src/__tests__/plugin/drainHttpServer/stoppable.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,13 @@ Object.keys(schemes).forEach((schemeName) => {
// idle connections in these versions. However, `Stopper` _is_ still
// useful for gracefully finishing in-flight requests within the timeout
// (and aborting requests beyond the timeout).
// Update: Node 18.19+ had this change backported, so the comment from above
// applies to Node 18.19+ as well.
const isNode18 = !!process.version.match(/^v18\./);
//
// (Node 18.19.0 had this change backported but it was removed again in
// 18.20.3; our tests only pin major versions so we can assume 18 means
// >= 18.20.3.) Update: Node 18.19+ had this change backported, so the
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, didn't delete the end of the comment

// comment from above applies to Node 18.19+ as well.
const isNode20 = !!process.version.match(/^v20\./);
expect(closed).toBe(isNode18 || isNode20 ? 1 : 0);
expect(closed).toBe(isNode20 ? 1 : 0);
});

// This test specifically added for Node 20 fails for Node 14. Just going
Expand Down