Fix test failure with Node 18.20.3 #7898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Our CI installs the latest version associated with a given Node version, so it started to fail when this started loading v18.20.3 which reverted the change backported to v18.19.
glasser
force-pushed
the
glasser/node-18-20-3
branch
from
0ec5868 to
543db82
Compare
✅ Deploy Preview for apollo-server-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
glasser
commented
Jul 10, 2024
| // | ||
| // (Node 18.19.0 had this change backported but it was removed again in | ||
| // 18.20.3; our tests only pin major versions so we can assume 18 means | ||
| // >= 18.20.3.) Update: Node 18.19+ had this change backported, so the |
There was a problem hiding this comment.
oops, didn't delete the end of the comment
glasser
added a commit
that referenced
this pull request
Jul 10, 2024
✅ Deploy Preview for apollo-server-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
glasser
added a commit
that referenced
this pull request
Jul 10, 2024
Meschreiber
pushed a commit
that referenced
this pull request
Jul 10, 2024
Our CI installs the latest version associated with a given Node version, so it started to fail when this started loading v18.20.3 which reverted the change backported to v18.19.
Meschreiber
pushed a commit
that referenced
this pull request
Jul 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI installs the latest version associated with a given Node version, so it started to fail when this started loading v18.20.3 which reverted the change backported to v18.19.