Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency accept to @hapi/accept and boom to @ha… #4254

Closed
wants to merge 3 commits into from
Closed

chore(deps): update dependency accept to @hapi/accept and boom to @ha… #4254

wants to merge 3 commits into from

Conversation

coyksdev
Copy link

This PR contains the following updates:

Package: accept
Change: accept: 3.0.2 -> @hapi/accept: 5.0.1

Package: boom
Change: boom: 7.1.0 -> @hapi/boom": 9.1.0

@apollo-cla
Copy link

@campanagerald: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@abernix abernix closed this Jun 24, 2020
@abernix abernix reopened this Jun 25, 2020
@abernix abernix changed the base branch from master to main June 25, 2020 09:01
@rtrys
Copy link

rtrys commented Apr 12, 2021

hi @apollo-cla / @campanagerald, can you go ahead with this PR?

@abernix abernix added this to the Release 3.x milestone Apr 13, 2021
@abernix abernix changed the base branch from main to release-3.0 April 13, 2021 11:14
@abernix
Copy link
Member

abernix commented Apr 13, 2021

We've started the upgrades to Hapi (core) in the release-3.0 branch, though these particular upgrades haven't been included yet. In that regard, I've gone ahead and re-targeted this to the release-3.0 branch and put this in the Release 3.x milestone.

However, I'm unsure how the changes in this PR (which just touch package.json and package-lock.json) would be sufficient on their own since there are imports of these modules that also would need to be changed (and possibly, the
API usage, too?).

@campanagerald Would you be taking that on?

@abernix abernix mentioned this pull request Apr 19, 2021
Closed
@rtrys
Copy link

rtrys commented Apr 27, 2021

hi @campanagerald, are you going to take care of this PR? I think it is an important change that must be included in the next release

glasser added a commit that referenced this pull request Apr 30, 2021
@glasser
Update Hapi to 20.1.2
48e5239 
This is the latest release, and the only release that supports Node 16, so it
will be the minimum version that we test again.

Also:
- Update `@types/hapi__hapi` to latest version. Note that you can import from
  `@hapi/hapi` successfully so adjust an import.
- Update `accept` and `boom` to their latest versions, which now have `@hapi/`
  prefix; this includes in apollo-server-micro for some reason.
- release-3.0 couldn't run tests after the last merge from main until this
  change was made; this revealed a failing test of a newly merged feature due to
  a change in a graphql-js error message. Fix that.

This incorporates suggestions from #3273, #3441, and #4254.
@glasser glasser mentioned this pull request Apr 30, 2021
Merged
@glasser
Copy link
Member

glasser commented Apr 30, 2021

This is now fixed on the release-3.0 branch via #5150. I incorporated parts of your PR into it. Thanks!

@glasser glasser closed this Apr 30, 2021
glasser added a commit that referenced this pull request Apr 30, 2021
@glasser
Update Hapi to 20.1.2 (#5150)
05e3667 
This is the latest release, and the only release that supports Node 16, so it
will be the minimum version that we test again.

Also:
- Update `@types/hapi__hapi` to latest version. Note that you can import from
  `@hapi/hapi` successfully so adjust an import.
- Update `accept` and `boom` to their latest versions, which now have `@hapi/`
  prefix; this includes in apollo-server-micro for some reason.
- release-3.0 couldn't run tests after the last merge from main until this
  change was made; this revealed a failing test of a newly merged feature due to
  a change in a graphql-js error message. Fix that.

This incorporates suggestions from #3273, #3441, and #4254.
@glasser glasser removed this from the Release 3.x milestone Jun 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@coyksdev @apollo-cla @rtrys @abernix @glasser