changed accept package to @hapi/accept in apollo-server-micro #3441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Himujjal: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
|
Installing the micro server still throws a bunch of warnings related to the hapi migration. Is this going to be merged at any point? |
|
It looks like |
glasser
added a commit
that referenced
this pull request
Apr 30, 2021
This is the latest release, and the only release that supports Node 16, so it will be the minimum version that we test again. Also: - Update `@types/hapi__hapi` to latest version. Note that you can import from `@hapi/hapi` successfully so adjust an import. - Update `accept` and `boom` to their latest versions, which now have `@hapi/` prefix; this includes in apollo-server-micro for some reason. - release-3.0 couldn't run tests after the last merge from main until this change was made; this revealed a failing test of a newly merged feature due to a change in a graphql-js error message. Fix that. This incorporates suggestions from #3273, #3441, and #4254.
Merged
|
This is now fixed on the |
glasser
added a commit
that referenced
this pull request
Apr 30, 2021
This is the latest release, and the only release that supports Node 16, so it will be the minimum version that we test again. Also: - Update `@types/hapi__hapi` to latest version. Note that you can import from `@hapi/hapi` successfully so adjust an import. - Update `accept` and `boom` to their latest versions, which now have `@hapi/` prefix; this includes in apollo-server-micro for some reason. - release-3.0 couldn't run tests after the last merge from main until this change was made; this revealed a failing test of a newly merged feature due to a change in a graphql-js error message. Fix that. This incorporates suggestions from #3273, #3441, and #4254.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply updated the accept@3.0.x package to @hapi/accept@4.0.0 which was being shown in the warning messages. No major change whatsoever