-
Notifications
You must be signed in to change notification settings - Fork 344
Conversation
Codecov Report
@@ Coverage Diff @@
## master #919 +/- ##
=======================================
Coverage 96.37% 96.37%
=======================================
Files 20 20
Lines 662 662
Branches 163 167 +4
=======================================
Hits 638 638
Misses 19 19
Partials 5 5 Continue to review full report at Codecov.
|
Not mergeable yet, still an issue with the cache |
I would also propose to reduce the filesize checks to more reasonable amounts:
|
Weird, the circleci is not starting again.... |
I think it will @JoviDeCroock - it's just being delayed by other queued up and running tests (related to other projects). |
Allright, being too hasty :D was trying to debug the issue but not really finding the queue issue atm |
…-link into chore/fix_ci * 'chore/fix_ci' of https://github.com/JoviDeCroock/apollo-link: chore(deps): update dependency graphql-tag to v2.10.1 chore(deps): update dependency bundlesize to v0.17.1 chore(deps): update dependency @types/graphql to v14.0.5 Changelog updates
Shouldn't we add monorepo step as required aswell? |
Yes, for sure - I couldn't add it when I was adjusting the checks last time, because a successful build hadn't completed yet. I can (and will) add it now. Thanks! |
Allright, thank you for the help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome @JoviDeCroock! I've added one comment, but it's more for us internally. Thanks very much for your work on this!
steps: | ||
- attach_workspace: | ||
at: . | ||
- <<: *attach | ||
- run: npm run lint-check | ||
|
||
Docs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we're building the docs like this in other repos, but I have a feeling this isn't really necessary. Our Netlify based docs build and deploy process is already taking care of this, and if the docs fail to build for any reason, an error will be reported by the Netlify GitHub check. Let's leave this docs CI step for now, but food for future thought.
Slight tweaks to get jest based coverage reporting working (they were changed #919).
This is a temp placeholder, so I can see what holds the CI up in our webview.
Caching etc seems covered now, could someone double check if there's any regression in things covered by the CI, I think not but yes I'm not that experienced with this repo yet.