Bring back all the pluralization #1879
Conversation
| @@ -83,7 +84,7 @@ public struct ApolloCodegenOptions { | |||
| /// - codegenEngine: The code generation engine to use. Defaults to `CodeGenerationEngine.default` | |||
| /// - includes: Glob of files to search for GraphQL operations. This should be used to find queries *and* any client schema extensions. Defaults to `./**/*.graphql`, which will search for `.graphql` files throughout all subfolders of the folder where the script is run. | |||
| /// - mergeInFieldsFromFragmentSpreads: Set true to merge fragment fields onto its enclosing type. Defaults to true. | |||
| /// - modifier: [EXPERIMENTAL SWIFT CODEGEN ONLY] - The access modifier to use on everything created by this tool. Defaults to `.public`. | |||
| /// - modifier: The access modifier to use on everything created by this tool. Defaults to `.public`. Only used by the Swift code generation engine. | |||
There was a problem hiding this comment.
This is fine for now. I think when we release the swift codegen, we will need to keep support for legacy codegen for a while, but that it should probably have its own set of options entirely so we can diverge more easily. But that's not a concern for today.
|
Wait, isn't all this about singularization 🤔 ? |
|
InflectorKit provides both and |
|
But we don't really need to pluralize? Or do we? |
|
I am not sure - @designatednerd may have a better answer to that question. |
|
I think we use it for things like {
hero {
# friends is a list type
friends {
name
}
}
}to generate a struct Friend {
let name: String
}I don't think we need the other way |
|
We primarily use it for singularization. Somewhere in the back of my mind I remember there was some point where we were also pluralizing but i'm having a memory read error on where. |
|
Aha, found it: #955, was trying to pluralize |
|
@designatednerd - with this merged we can probably drop our fork of InflectorKit. |
|
Yes, though I would not recommend deleting it since then it won't resolve for older versions of the lib |
* Revert "Remove inflection option, pluralizer and dependency" * Move from InflectorKit fork to origin with 1.0.0 minimum * Update to comply with InflectorKit 1.0.0 deprecations * Enable code generation options to accept additional inflection rules * Update PluralizerTest function names to match #1849 * Shuffle parameter documentation order to match parameter input order
* Revert "Remove inflection option, pluralizer and dependency" * Move from InflectorKit fork to origin with 1.0.0 minimum * Update to comply with InflectorKit 1.0.0 deprecations * Enable code generation options to accept additional inflection rules * Update PluralizerTest function names to match #1849 * Shuffle parameter documentation order to match parameter input order
* Revert "Remove inflection option, pluralizer and dependency" * Move from InflectorKit fork to origin with 1.0.0 minimum * Update to comply with InflectorKit 1.0.0 deprecations * Enable code generation options to accept additional inflection rules * Update PluralizerTest function names to match #1849 * Shuffle parameter documentation order to match parameter input order
This is a revert of 42a75f2 with some changes
1.0.0PluralizerTestswas updated to comply with deprecated function namesPluralizerTestsfunction names to match Update tests to follow naming convention #1849