Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to follow naming convention #1849

Open
8 of 60 tasks
calvincestari opened this issue Jun 25, 2021 · 0 comments
Open
8 of 60 tasks

Update tests to follow naming convention #1849

calvincestari opened this issue Jun 25, 2021 · 0 comments
Labels
testing

Comments

@calvincestari
Copy link
Member

calvincestari commented Jun 25, 2021 •
edited
Loading

This hasn't been the pattern used in the past, but we're suggesting an improvement for naming test functions. It makes for a better understanding of what's being tested and what the expected behavior is.

The naming convention to adopt is test_${thing-being-tested}_given${parameters-or-details}_(will|should|does|doesNot)${expected-behavior}. See here as an example.

Use this issue to track the tests that have been updated and those remaining; we don't need to get it all done in one PR.

ApolloCodegenTests

  • ApolloCodegenTests
  • ApolloSchemaPublicTests
  • ApolloSchemaInternalTests
  • CLIDownloaderTests
  • CLIExtractorTests
  • CompilationTests
  • DocumentParsingAndValidationTests
  • FileManagerExtensionsTests
  • SchemaIntrospectionTests
  • SchemaLoadingTests
  • URLDownloaderTests
  • URLExtensionsTests

ApolloPerformanceTests

  • ParsingPerformanceTests

ApolloServerIntegrationTests

  • DefaultInterceptorProviderIntegrationTests
  • SchemaRegistryApolloSchemaDownloaderTests
  • StarWarsApolloSchemaDownloaderTests
  • SQLiteStarWarsServerCachingRoundtripTests
  • SQLiteStarWarsServerTests
  • StarWarsSubscriptionTests
  • StarWarsWebSocketTests
  • UploadTests
  • URLSessionClientLiveTests

ApolloTests

  • ApolloClientOperationTests
  • AutomaticPersistedQueriesTests
  • BatchedLoadTests
  • CacheDependentInterceptorTests
  • CacheKeyForFieldTests
  • CachePersistenceTests
  • CompressionTests
  • DataLoaderTests
  • DefaultInterceptorProviderTests
  • ErrorGenerationTests
  • ExecutionTests
  • FetchQueryTests
  • FragmentConstructionAndConversionTests
  • GETTransformerTests
  • GraphQLFileTests
  • GraphQLMapEncodingTests
  • InterceptorTests
  • JSONTests
  • LoadQueryFromStoreTests
  • MultipartFormDataTests
  • MutatingResultsTests
  • NormalizeQueryResults
  • OperationMessageIdCreatorTests
  • ParseQueryResponseTests
  • PossiblyDeferredTests
  • QueryFromJSONBuildingTests
  • ReadFieldValueTests
  • ReadWriteFromStoreTests
  • RequestBodyCreatorTests
  • RequestChainTests
  • SplitNetworkTransportTests
  • SQLiteDotSwiftDatabaseBehaviorTests
  • StoreConcurrencyTests
  • UploadRequestTests
  • VersionNumberTests
  • WatchQueryTests
  • WebSocketTests
  • WebSocketTransportTests
@calvincestari calvincestari mentioned this issue Jun 25, 2021
Merged
calvincestari added a commit that referenced this issue Jul 20, 2021
@calvincestari
Update test function names to match #1849
fa58b4d
@calvincestari calvincestari mentioned this issue Jul 20, 2021
Merged
calvincestari added a commit that referenced this issue Jul 21, 2021
@calvincestari
Codegen test updates (#1877)
3e768ed 
* Add Swift codegen engine argument test
* Update test function names to match #1849
* Remove test file attribution header
calvincestari added a commit that referenced this issue Jul 21, 2021
@calvincestari
Update PluralizerTest function names to match #1849
c7f720f
@calvincestari calvincestari mentioned this issue Jul 21, 2021
Merged
calvincestari added a commit that referenced this issue Jul 21, 2021
@calvincestari
Bring back all the pluralization (#1879)
a7d11c8 
* Revert "Remove inflection option, pluralizer and dependency"
* Move from InflectorKit fork to origin with 1.0.0 minimum
* Update to comply with InflectorKit 1.0.0 deprecations
* Enable code generation options to accept additional inflection rules
* Update PluralizerTest function names to match #1849
* Shuffle parameter documentation order to match parameter input order
calvincestari added a commit that referenced this issue Aug 13, 2021
@calvincestari
Codegen test updates (#1877)
18ccdd0 
* Add Swift codegen engine argument test
* Update test function names to match #1849
* Remove test file attribution header
calvincestari added a commit that referenced this issue Aug 13, 2021
@calvincestari
Bring back all the pluralization (#1879)
60ee315 
* Revert "Remove inflection option, pluralizer and dependency"
* Move from InflectorKit fork to origin with 1.0.0 minimum
* Update to comply with InflectorKit 1.0.0 deprecations
* Enable code generation options to accept additional inflection rules
* Update PluralizerTest function names to match #1849
* Shuffle parameter documentation order to match parameter input order
calvincestari added a commit that referenced this issue Aug 23, 2021
@calvincestari
Codegen test updates (#1877)
af2c1ec 
* Add Swift codegen engine argument test
* Update test function names to match #1849
* Remove test file attribution header
calvincestari added a commit that referenced this issue Aug 23, 2021
@calvincestari
Bring back all the pluralization (#1879)
7bf2e62 
* Revert "Remove inflection option, pluralizer and dependency"
* Move from InflectorKit fork to origin with 1.0.0 minimum
* Update to comply with InflectorKit 1.0.0 deprecations
* Enable code generation options to accept additional inflection rules
* Update PluralizerTest function names to match #1849
* Shuffle parameter documentation order to match parameter input order
calvincestari added a commit that referenced this issue Sep 3, 2021
@calvincestari
Codegen test updates (#1877)
0c6b976 
* Add Swift codegen engine argument test
* Update test function names to match #1849
* Remove test file attribution header
calvincestari added a commit that referenced this issue Sep 3, 2021
@calvincestari
Bring back all the pluralization (#1879)
0808589 
* Revert "Remove inflection option, pluralizer and dependency"
* Move from InflectorKit fork to origin with 1.0.0 minimum
* Update to comply with InflectorKit 1.0.0 deprecations
* Enable code generation options to accept additional inflection rules
* Update PluralizerTest function names to match #1849
* Shuffle parameter documentation order to match parameter input order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@calvincestari