Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Fixed link namespace published items show missing some items #5240

Merged

Conversation

youngzil
Copy link
Contributor

@youngzil youngzil commented Sep 26, 2024

What's the purpose of this PR

XXXXX

Which issue(s) this PR fixes:

Fixes #5237

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

Summary by CodeRabbit

  • New Features
    • Enhanced visibility in the namespace panel by displaying old values for modified or deleted items.
    • Improved item display logic with character limits and ellipsis for better readability.
  • Bug Fixes
    • Resolved an issue where some published items were missing from the namespace display.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 26, 2024
Copy link
Contributor

coderabbitai bot commented Sep 26, 2024

Walkthrough

The changes in this pull request modify the display logic for items in the namespace panel of the Apollo portal. The conditions for rendering items have been expanded to include checks for config.oldValue, allowing old values to be shown for modified or deleted items. The ng-click directive has been updated to conditionally show either the old or current value based on the item's status. Additionally, the character limit for displayed values has been set to 250 characters, with ellipses for longer texts.

Changes

File Change Summary
apollo-portal/src/main/resources/static/views/component/namespace-panel-master-tab.html Updated ng-if and ng-click conditions to include config.oldValue; adjusted display logic for item values.
CHANGES.md Added entry for Apollo version 2.4.0 addressing display issues for published items.

Assessment against linked issues

Objective Addressed Explanation
Display modified or deleted configurations in the tab (5237)
Ensure old values are shown when applicable (5237)
Maintain current value display for unmodified items (5237)

Possibly related PRs

Poem

In the namespace where values play,
Old and new now find their way.
With a click, the past unfolds,
In 250 characters, a story told.
Hooray for changes, bright and clear,
A rabbit's cheer, let’s all draw near! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! BTW, please update the CHANGES.md.

@youngzil
Copy link
Contributor Author

CHANGES.md

Already added CHANGES.md

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
CHANGES.md (1)

11-11: LGTM with a minor suggestion for clarity.

The changelog entry correctly addresses the issue described in the PR objectives and follows the consistent format of other entries. The link to the PR is accurate.

Consider slightly rewording the entry for improved clarity:

-* [Fix link namespace published items show missing some items](https://github.com/apolloconfig/apollo/pull/5240)
+* [Fix: Linked namespace published items now show previously missing items](https://github.com/apolloconfig/apollo/pull/5240)

This rewording maintains the essence of the fix while making it slightly more descriptive and easier to understand at a glance.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between adf9e04 and 1ae78eb.

📒 Files selected for processing (1)
  • CHANGES.md (1 hunks)

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 30, 2024
@nobodyiam nobodyiam merged commit c6b165d into apolloconfig:master Sep 30, 2024
7 of 8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
@youngzil youngzil deleted the fix/link_namespace_published_items_show branch September 30, 2024 02:58
@nobodyiam nobodyiam added this to the 2.4.0 milestone Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apollo关联namespace展示问题
2 participants