-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:Fixed link namespace published items show missing some items #5240
fix:Fixed link namespace published items show missing some items #5240
Conversation
WalkthroughThe changes in this pull request modify the display logic for items in the namespace panel of the Apollo portal. The conditions for rendering items have been expanded to include checks for Changes
Assessment against linked issues
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! BTW, please update the CHANGES.md.
Already added CHANGES.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
CHANGES.md (1)
11-11
: LGTM with a minor suggestion for clarity.The changelog entry correctly addresses the issue described in the PR objectives and follows the consistent format of other entries. The link to the PR is accurate.
Consider slightly rewording the entry for improved clarity:
-* [Fix link namespace published items show missing some items](https://github.com/apolloconfig/apollo/pull/5240) +* [Fix: Linked namespace published items now show previously missing items](https://github.com/apolloconfig/apollo/pull/5240)This rewording maintains the essence of the fix while making it slightly more descriptive and easier to understand at a glance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
XXXXX
Which issue(s) this PR fixes:
Fixes #5237
Brief changelog
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.Summary by CodeRabbit