Skip to content

Commit

Permalink
fix:Fixed link namespace published items show missing some items (#5240)
Browse files Browse the repository at this point in the history
* fix:Fixed link namespace published items show missing some items

* fix:add CHANGES.md
  • Loading branch information
youngzil authored Sep 30, 2024
1 parent 7e7b090 commit c6b165d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Apollo 2.4.0
* [Update the server config link in system info page](https://github.com/apolloconfig/apollo/pull/5204)
* [Feature support portal restTemplate Client connection pool config](https://github.com/apolloconfig/apollo/pull/5200)
* [Feature added the ability for administrators to globally search for Value](https://github.com/apolloconfig/apollo/pull/5182)
* [Fix link namespace published items show missing some items](https://github.com/apolloconfig/apollo/pull/5240)

------------------
All issues and pull requests are [here](https://github.com/apolloconfig/apollo/milestone/15?closed=1)
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,7 @@ <h5>{{'Component.Namespace.Master.Items.Body.Link.NoCoverLinkItem' | translate }
</thead>
<tbody>
<tr ng-repeat="config in namespace.publicNamespace.viewItems |orderBy:col:desc"
ng-if="config.item.key && !config.isModified && !config.isDeleted">
ng-if="config.item.key && ((!config.isModified && !config.isDeleted) || config.oldValue)">
<td width="15%" class="cursor-pointer"
title="{{'Component.Namespace.Master.Items.Body.ClickToSee' | translate }}"
ng-click="showText(config.item.key)">
Expand All @@ -643,9 +643,11 @@ <h5>{{'Component.Namespace.Master.Items.Body.Link.NoCoverLinkItem' | translate }
</td>
<td width="30%" class="cursor-pointer"
title="{{'Component.Namespace.Master.Items.Body.ClickToSee' | translate }}"
ng-click="showText(config.item.value)">
<span ng-bind="config.item.value | limitTo: 250"></span>
<span ng-bind="config.item.value.length > 250 ? '...': ''"></span>
ng-click="(config.isModified || config.isDeleted) ? showText(config.oldValue) : showText(config.item.value)">
<span ng-if="config.isModified || config.isDeleted" ng-bind="config.oldValue | limitTo: 250"></span>
<span ng-if="config.isModified || config.isDeleted" ng-bind="config.oldValue.length > 250 ? '...': ''"></span>
<span ng-if="!config.isModified && !config.isDeleted" ng-bind="config.item.value | limitTo: 250"></span>
<span ng-if="!config.isModified && !config.isDeleted" ng-bind="config.item.value.length > 250 ? '...': ''"></span>
</td>
<td width="13%" title="{{config.item.comment}}">
<span ng-bind="config.item.comment | limitTo: 250"></span>
Expand Down

0 comments on commit c6b165d

Please sign in to comment.