Merge branch 'master' into feature/namespace-item-num-limit

# Conflicts: # CHANGES.md
apolloconfig · Sep 30, 2024 · 998459e · 998459e
2 parents ea19b4e + c6b165d
commit 998459e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -8,6 +8,7 @@ Apollo 2.4.0
 * [Update the server config link in system info page](https://github.com/apolloconfig/apollo/pull/5204)
 * [Feature support portal restTemplate Client connection pool config](https://github.com/apolloconfig/apollo/pull/5200)
 * [Feature added the ability for administrators to globally search for Value](https://github.com/apolloconfig/apollo/pull/5182)
+* [Fix link namespace published items show missing some items](https://github.com/apolloconfig/apollo/pull/5240)
 * [Feature added limit the number of items under a single namespace](https://github.com/apolloconfig/apollo/pull/5228)
 
 ------------------

diff --git a/apollo-portal/src/main/resources/static/views/component/namespace-panel-master-tab.html b/apollo-portal/src/main/resources/static/views/component/namespace-panel-master-tab.html
@@ -624,7 +624,7 @@ <h5>{{'Component.Namespace.Master.Items.Body.Link.NoCoverLinkItem' | translate }
                                 </thead>
                                 <tbody>
                                     <tr ng-repeat="config in namespace.publicNamespace.viewItems |orderBy:col:desc"
-                                        ng-if="config.item.key && !config.isModified && !config.isDeleted">
+                                        ng-if="config.item.key && ((!config.isModified && !config.isDeleted) || config.oldValue)">
                                         <td width="15%" class="cursor-pointer"
                                             title="{{'Component.Namespace.Master.Items.Body.ClickToSee' | translate }}"
                                             ng-click="showText(config.item.key)">
@@ -643,9 +643,11 @@ <h5>{{'Component.Namespace.Master.Items.Body.Link.NoCoverLinkItem' | translate }
                                         </td>
                                         <td width="30%" class="cursor-pointer"
                                             title="{{'Component.Namespace.Master.Items.Body.ClickToSee' | translate }}"
-                                            ng-click="showText(config.item.value)">
-                                            <span ng-bind="config.item.value | limitTo: 250"></span>
-                                            <span ng-bind="config.item.value.length > 250 ? '...': ''"></span>
+                                            ng-click="(config.isModified || config.isDeleted) ? showText(config.oldValue) : showText(config.item.value)">
+                                            <span ng-if="config.isModified || config.isDeleted" ng-bind="config.oldValue | limitTo: 250"></span>
+                                            <span ng-if="config.isModified || config.isDeleted" ng-bind="config.oldValue.length > 250 ? '...': ''"></span>
+                                            <span ng-if="!config.isModified && !config.isDeleted" ng-bind="config.item.value | limitTo: 250"></span>
+                                            <span ng-if="!config.isModified && !config.isDeleted" ng-bind="config.item.value.length > 250 ? '...': ''"></span>
                                         </td>
                                         <td width="13%" title="{{config.item.comment}}">
                                             <span ng-bind="config.item.comment | limitTo: 250"></span>