Skip to content

Remove possibility to add organisation managers by username #3438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2018

Conversation

matleppa
Copy link
Member

Closes #3437

Temporary quick and dirty correction in Organization manager handling.

Changes

  • show only managers' email address, not username
  • add manager only with email address, not with username

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project style guide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @username1

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

- show only managers' email address, not username
- add manager only with email address, not with username
@ghost ghost assigned matleppa Mar 22, 2018
@ghost ghost added the in progress label Mar 22, 2018
@matleppa matleppa requested a review from 55 March 22, 2018 14:51
@55 55 merged commit 8f421fc into develop Mar 22, 2018
@ghost ghost removed the Ready for review label Mar 22, 2018
@55 55 deleted the bugfix/prevent-add-org-manager-by-username branch March 22, 2018 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants