hydra:view schema validation (#967) #970
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix Behatch namespace * Fix all hydra:view pattern check in json schema validation * Bump Behatch requirement
|
Wow I think I can't do that this way because it's out-of-date with the base branch, any clue @teohhanhui ? I don't want to break everything :p but I think that I should do : |
|
Sorry I was not available but it is exactly what you need to do :) |
|
:D done and I updated the existsFilter along the way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @teohhanhui just doing this on github so that we all know I did it and to see if tests are okay \o/.
This is a prerequisite to fix #906 so that we finally can merge it!