hydra:view schema validation #967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antograssiot
force-pushed
the
hydraview-test
branch
from
1093815 to
c11ee29
Compare
Merged
teohhanhui
approved these changes
Mar 6, 2017
dunglas
approved these changes
Mar 6, 2017
|
@dunglas do you want me to rebase and/or retarget to 2.0 ? |
|
It will help yes. |
They proabbly never heard of semver :(
antograssiot
force-pushed
the
hydraview-test
branch
from
7f88a66 to
da80376
Compare
|
@dunglas rebased and retarget as requested |
|
Thanks @antograssiot |
|
@dunglas shouldn't this be added to master too? |
|
@antograssiot Why didn't you update composer.lock as well? |
|
@desmax probably because this file is not in the repo (nor should be IMO)... |
|
@antograssiot oh, my bad. sorry for disturbance |
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
* Fix Behatch namespace * Fix all hydra:view pattern check in json schema validation * Bump Behatch requirement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that the hydra:view schema validation pattern were not correctly checked in the testsuite. Any value would let the tests passing as the schema is malformed.
I've also updated the Behatch namespace as they changed it in 2.6 (call it deprecated) without providing a decent BC version.