Disable Messenger From Config#2489
Merged
dunglas merged 1 commit intoapi-platform:2.4from Feb 3, 2019
Merged
Conversation
ragboyjr
force-pushed
the
disable-messenger-from-config
branch
from
2447776 to
e850be6
Compare
dunglas
approved these changes
Feb 3, 2019
Member
dunglas
left a comment
dunglas
left a comment
There was a problem hiding this comment.
Good one too! Can you run PHP CS Fixer please?
- Added ability to disable messenger from config - Removed previous check if container has message_bus Signed-off-by: RJ Garcia <rj@bighead.net>
ragboyjr
force-pushed
the
disable-messenger-from-config
branch
from
e850be6 to
aa7bb63
Compare
Contributor
Author
|
@dunglas CS fixed, squashed and pushed up. |
Member
|
Thanks @ragboyjr! |
Contributor
|
I don't think it's ideal that the user should get an error and have to manually disable the Symfony Messenger integration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: RJ Garcia rj@bighead.net