2.4.0 beta is not compatible with symfony 4.2

[lyrixx]

I was too excited to test 2.4.0 so I updated it, but it failed:

In CheckExceptionOnInvalidReferenceBehaviorPass.php line 86:
                                                                                                                 
  The service "api_platform.messenger.data_persister" has a dependency on a non-existent service "message_bus".           

We are using

symfony/symfony                      v4.2.1           The Symfony PHP framework

(yes, no flex, because it's an "old" application, but we get new releases anyway)

[pcox64]

I fixed this in an upgraded Symfony 3 application by composer require symfony/messenger and adding the following under framework to config.yml:

messenger:
  default_bus: ~

[soyuka]

This may need a fix on symfony's side no?

[lyrixx]

IMHO, no. either you make the messenger component mandatory, or you use it only if the service is here.

[soyuka]

I'll fix this asap

[lyrixx]

Thanks

[soyuka]

Mhh it's weird, we do have a check and load the messenger.xml only when the interface exists:

https://github.com/api-platform/core/blob/2.4/src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php#L154-L156

[lyrixx]

Class exisit is different from service exisit

[ragboyjr]

@soyuka @lyrixx messenger_bus is a private service. When running off of the latest api-platform 2.4, this fails to load the messenger component, since $container->has('message_bus') is always false.

Checking how symfony's FrameworkBundle works, they don't ever check if a service exists, instead they do an interface exists check (like what we currently have and what was there previously), and in some cases, they check a config value to see if the module should be enabled or not.

@lyrixx correct me if i'm wrong, but if if you were getting that error, that means that you had symfony/messenger component installed but due to some configuration, the message bus service didn't exist.

I think we should revert the $container->has('messenger.message_bus') since it doesn't work, and possibly see about adding a config option to enable/disable messenger integration entirely since messenger isn't a stable component.