ZOOKEEPER-4864: Fix bad format when dump MultiTxn in TxnLogToolkit #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezhuw
reviewed
Sep 28, 2024
There was a problem hiding this comment.
Hi @luoxiner, thank you for your contribution! The direction is good to me. I left some comments regarding the code. Please take a look, thanks.
cc @maoling in case you are interesting according to #1915 (comment)
zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/TxnLogToolkit.java
Outdated
Show resolved
Hide resolved
zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/TxnLogToolkit.java
Outdated
Show resolved
Hide resolved
zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/TxnLogToolkit.java
Outdated
Show resolved
Hide resolved
zookeeper-server/src/test/java/org/apache/zookeeper/server/persistence/TxnLogToolkitTest.java
Outdated
Show resolved
Hide resolved
zookeeper-server/src/test/java/org/apache/zookeeper/server/persistence/TxnLogToolkitTest.java
Outdated
Show resolved
Hide resolved
decode Txn to record and format the output with record for better format.
luoxiner
force-pushed
the
ZOOKEEPER-4864
branch
from
57b5caa to
ae25ced
Compare
|
@kezhuw thanks for your review ! I push a new commit, please take a look. |
kezhuw
approved these changes
Sep 28, 2024
tisonkun
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the TxnLogToolkit only decodes error transactions to recognized strings. This PR seeks to enhance the toolkit to decode other types of transactions into a better format.
Associated jira issue ZOOKEEPER-4864