Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-4607 : Fix decode problem when sub tnx type is error. #1915

Merged
merged 8 commits into from
Jul 18, 2023

Conversation

horizonzy
Copy link
Member

@horizonzy horizonzy commented Aug 18, 2022

If there is a -101 error in the multi txn, the error byte array is {-1, -1, -1, -101}.

In the TxnLogToolkit, it uses toString to decode, it will decode it to the unknown character.

Before:

session 0x1000017f0b701dc cxid 0x1 zxid 0x3208 multi error:����;error:����;error:����

After:

session 0x1000017f0b701dc cxid 0x1 zxid 0x3208 multi error:-101;error:-2;error:-2

@horizonzy horizonzy changed the title Fix decode problem when sub tnx type is error. ZOOKEEPER-4607 : Fix decode problem when sub tnx type is error. Aug 18, 2022
@horizonzy
Copy link
Member Author

@maoling PTAL.

@horizonzy
Copy link
Member Author

@eolivelli PTAL.

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thank you !

@horizonzy horizonzy closed this Jul 18, 2023
@horizonzy horizonzy reopened this Jul 18, 2023
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Merging...

@tisonkun tisonkun merged commit 6e746f8 into apache:master Jul 18, 2023
rahulrane50 pushed a commit to rahulrane50/zookeeper that referenced this pull request Sep 15, 2023
AlphaCanisMajoris pushed a commit to AlphaCanisMajoris/zookeeper that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants