YETUS-1106. Detect CMake test changes #215
Conversation
* The regex used to detect test changes only caters to the case where there's a directory named "test". * Conventionally, the tests in CMake are put under a directory named "tests". This causes the regex match to fail and thus results in a -1 for test4tests. * We handle this case by matching "test" with an optional trailing "s".
|
This PR fixes the issue seen in the CI runs of apache/hadoop#2792. |
|
@aajisaka , @aw-was-here could you please review my PR? I'm not sure why linkcheck is failing. It seems unrelated to my PR. |
|
@aajisaka could you please review my PR? This'll help in getting a green +1 on HDFS native client PRs. |
|
@ajayyadava could you please review my PR? This helps in getting clean runs on HDFS native client PRs (basically, any PR that involves CMake). |
|
The patch looks good to me. Linkcheck failure seems unrelated. |
|
Thanks @aajisaka. Could you please merge this PR then? |
|
https://github.com/apache/yetus/pull/215/checks?check_run_id=2283960122#step:4:9402 |
|
Started linkcheck test again. I'll merge this after it passed. |
|
Merged. Thank you @GauthamBanasandra |
only caters to the case where there's
a directory named "test".
put under a directory named "tests".
This causes the regex match to fail and
thus results in a -1 for test4tests.
with an optional trailing "s".