-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HDFS-15909. Make fnmatch cross platform #2792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
b1d26ec
to
adf40a1
Compare
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/fs/filesystem.cc
Show resolved
Hide resolved
💔 -1 overall
This message was automatically generated. |
adf40a1
to
8eadda4
Compare
💔 -1 overall
This message was automatically generated. |
8eadda4
to
d5f554a
Compare
💔 -1 overall
This message was automatically generated. |
d5f554a
to
39ce02d
Compare
💔 -1 overall
This message was automatically generated. |
39ce02d
to
c4d3ed7
Compare
💔 -1 overall
This message was automatically generated. |
c4d3ed7
to
ecc17d0
Compare
💔 -1 overall
This message was automatically generated. |
ecc17d0
to
6b6f0f1
Compare
💔 -1 overall
This message was automatically generated. |
6b6f0f1
to
f6b8465
Compare
💔 -1 overall
This message was automatically generated. |
f6b8465
to
bd65c77
Compare
💔 -1 overall
This message was automatically generated. |
* fnmatch.h isn't available on Visual C++ compiler.This PR makes it cross platform by using fnmatch on Linux and PathMatchSpecA on Windows appropriately.
* Removed fnmatch.h and iostream as they're not used in filesystem.cc
* Added unit tests for fnmatch in XPlatform.
* Renamed the target x_platform_utils_obj to x_platform_obj as was needed by rebasing on top of trunk.
bd65c77
to
b11e979
Compare
💔 -1 overall
This message was automatically generated. |
compiler.This PR makes it cross
platform by using fnmatch on Linux and
PathMatchSpecA on Windows appropriately.