Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] DataType Bug In SplitRel #8899

Merged
merged 2 commits into from
Sep 2, 2021
Merged

[BUG] DataType Bug In SplitRel #8899

merged 2 commits into from
Sep 2, 2021

Conversation

wangxiang2713
Copy link
Contributor

Elements in param->indices_or_sections are int64, which cause oshape[axis] calculated it int64 while other elements in oshape are int32, which cause check error in codegen phase.

@vinx13
Copy link
Member

vinx13 commented Sep 1, 2021

Thanks for the PR, could you add a test case?

@vinx13 vinx13 added the status: need test case need test cases to cover the change label Sep 1, 2021
@wangxiang2713
Copy link
Contributor Author

Thanks for the PR, could you add a test case?

Hi, a test case just added. This case may occur when convert a tensorflow model. As this code will be excute:

size_splits = _get_param(params, inputs[1])
section_beginnings = np.cumsum(size_splits)[:-1]
indices_or_sections = tuple(section_beginnings)

np.cumsum outputs array with elements in int64.

@vinx13 vinx13 removed the status: need test case need test cases to cover the change label Sep 2, 2021
@vinx13 vinx13 merged commit 7deebc6 into apache:main Sep 2, 2021
AndrewZhaoLuo added a commit to AndrewZhaoLuo/tvm that referenced this pull request Sep 2, 2021
* main:
  [UnitTests][Contrib] Enable contrib tensorrt/coreml unit tests (apache#8902)
  [BUG] DataType Bug In SplitRel (apache#8899)
  Enable python debug runtime for exported network libraries (apache#8793)
  Set default value of p in LpPool as 2 (apache#8866)
  [Community] @Hzfengsy -> Committer (apache#8908)
  Trivial uTVM -> microTVM "spelling" fix to align with branding. (apache#8905)
  [Vulkan][Topi] Parametrizing additional topi tests, marking vulkan failures (apache#8904)
  Move to new style issue template system (apache#8898)
  [Onnx] Support Negative Log Loss (apache#8872)
  [ROCm][TVMC] Add ROCm to the TVMC driver (apache#8896)
  fix error report on Store (apache#8895)
  [Docker] Re-enabled automatic --tty flag when running bash. (apache#8861)
@wangxiang2713 wangxiang2713 deleted the commit_2 branch September 22, 2021 05:18
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
* [BUG] DataType Bug In SplitRel

* Add Test Case
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
* [BUG] DataType Bug In SplitRel

* Add Test Case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants