Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TVMScript] Fix error reporting on Store #8895

Merged
merged 1 commit into from
Sep 1, 2021
Merged

[TVMScript] Fix error reporting on Store #8895

merged 1 commit into from
Sep 1, 2021

Conversation

Hzfengsy
Copy link
Member

@Hzfengsy Hzfengsy commented Sep 1, 2021

Reported by @vinx13.

The error report after fix:

error: Store is only allowed with one index, but 2 were provided.
 --> tests/python/unittest/test_tvmscript_error_report.py:390:15
     |
 390 |              B[i, j] = 1.0  # error: Store is only allowed with one index
     |                ^^^^

cc @junrushao1994 @tkonolige

@Hzfengsy Hzfengsy mentioned this pull request Sep 1, 2021
Closed
tkonolige
tkonolige requested changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@tkonolige tkonolige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Hzfengsy, just a little thing to fix.

@vinx13
Copy link
Member

vinx13 commented Sep 1, 2021

Thanks for the fix!

tkonolige
tkonolige approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@tkonolige tkonolige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I misread the code earlier. This looks good as is. Thank you!

@vinx13 vinx13 merged commit 8e27d6c into apache:main Sep 1, 2021
AndrewZhaoLuo added a commit to AndrewZhaoLuo/tvm that referenced this pull request Sep 2, 2021
@AndrewZhaoLuo
Merge branch 'main' into aluo/onnx/sceloss
4e43297 
* main:
  [UnitTests][Contrib] Enable contrib tensorrt/coreml unit tests (apache#8902)
  [BUG] DataType Bug In SplitRel (apache#8899)
  Enable python debug runtime for exported network libraries (apache#8793)
  Set default value of p in LpPool as 2 (apache#8866)
  [Community] @Hzfengsy -> Committer (apache#8908)
  Trivial uTVM -> microTVM "spelling" fix to align with branding. (apache#8905)
  [Vulkan][Topi] Parametrizing additional topi tests, marking vulkan failures (apache#8904)
  Move to new style issue template system (apache#8898)
  [Onnx] Support Negative Log Loss (apache#8872)
  [ROCm][TVMC] Add ROCm to the TVMC driver (apache#8896)
  fix error report on Store (apache#8895)
  [Docker] Re-enabled automatic --tty flag when running bash. (apache#8861)
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
@Hzfengsy @ylc
fix error report on Store (apache#8895)
ef69967
@Hzfengsy Hzfengsy deleted the fix_parser branch October 2, 2021 07:13
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@Hzfengsy @ylc
fix error report on Store (apache#8895)
b218d36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkonolige tkonolige tkonolige approved these changes

@vinx13 vinx13 vinx13 approved these changes

@areusch areusch Awaiting requested review from areusch

@comaniac comaniac Awaiting requested review from comaniac

@jroesch jroesch Awaiting requested review from jroesch

@junrushao junrushao Awaiting requested review from junrushao

@merrymercy merrymercy Awaiting requested review from merrymercy

@tqchen tqchen Awaiting requested review from tqchen

@yzhliu yzhliu Awaiting requested review from yzhliu

@zhiics zhiics Awaiting requested review from zhiics

Assignees
No one assigned
Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hzfengsy @vinx13 @tkonolige