[Frontend,TOPI] Improve dynamism for BatchMatmul and Dense #7496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bator-tvm into tmp
monklof
changed the title
monklof
force-pushed
the
improve_dynamism
branch
from
138f478 to
ea41b92
Compare
comaniac
requested changes
Feb 26, 2021
Contributor
comaniac
left a comment
comaniac
left a comment
There was a problem hiding this comment.
Also cc @kevinthesun @yongwww for checking the tensorflow frontend changes.
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
comaniac
requested changes
Mar 16, 2021
Contributor
comaniac
left a comment
comaniac
left a comment
There was a problem hiding this comment.
Also please add test cases to cover your changes.
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
Contributor
Author
@comaniac Thanks a lot! Test case has been added for the frontend's changes, and the existing test cases can hit the code changes in TOPI(dense and batch_matmul) |
Contributor
|
Thanks @monklof |
comaniac
removed
status: need review
status: need update
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
* [TOPI] Dense cuda schedule support dynamic dimension * [TOPI] batch_matmul cublas te computation support dynamism * [Frontend] tensorflow frontend: dynamic support for BatchMatmul * [TOPI] nn batch_matmul te computation support dynamism * fix CI * Update python/tvm/topi/nn/batch_matmul.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> * Update python/tvm/topi/cuda/batch_matmul.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> * remove concat_dynamic_shape function * update topi dense op integer checking * fix ci * Update python/tvm/relay/frontend/tensorflow.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> * Update batch_matmul.py * [Frontend] add test for batch_matmul in dynamic shaped case Co-authored-by: Cody Yu <comaniac0422@gmail.com>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
* [TOPI] Dense cuda schedule support dynamic dimension * [TOPI] batch_matmul cublas te computation support dynamism * [Frontend] tensorflow frontend: dynamic support for BatchMatmul * [TOPI] nn batch_matmul te computation support dynamism * fix CI * Update python/tvm/topi/nn/batch_matmul.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> * Update python/tvm/topi/cuda/batch_matmul.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> * remove concat_dynamic_shape function * update topi dense op integer checking * fix ci * Update python/tvm/relay/frontend/tensorflow.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> * Update batch_matmul.py * [Frontend] add test for batch_matmul in dynamic shaped case Co-authored-by: Cody Yu <comaniac0422@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @kevinthesun @zhiics
Thanks for @comaniac 's advices, this is the merged pr for #7491 #7492 #7493 #7494