Skip to content

[Bugfix][Relay][Keras] Fix UpSampling2D about the wrong assertion about size #15082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
echuraev merged 3 commits into from
Jun 14, 2023
Merged

[Bugfix][Relay][Keras] Fix UpSampling2D about the wrong assertion about size #15082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2333c8
fix wrong assertion about unsample in keras.py
jikechao Jun 13, 2023
4dcd682
Update test_forward.py
jikechao Jun 13, 2023
c6163a6
Update test_forward.py
jikechao Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions python/tvm/relay/frontend/keras.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,10 +767,8 @@ def _convert_upsample(
params["scale_h"] = h
elif upsample_type == "UpSampling2D":
h, w = keras_layer.size
if h != w:
raise tvm.error.OpAttributeInvalid("Height must equal width for operator Upsample.")
params["scale_h"] = h
params["scale_w"] = h
params["scale_w"] = w

if hasattr(keras_layer, "interpolation"):
interpolation = keras_layer.interpolation
Expand Down
5 changes: 5 additions & 0 deletions tests/python/frontend/keras/test_forward.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,11 @@ def test_forward_upsample(self, keras_mod, interpolation="nearest"):
x = keras_mod.layers.UpSampling2D(size=(3, 3), interpolation=interpolation)(data)
keras_model = keras_mod.models.Model(data, x)
verify_keras_frontend(keras_model)
# Height and width are not equal for the attribute size
data = keras_mod.layers.Input(shape=(2, 1, 3))
x = keras_mod.layers.UpSampling2D(size=(1, 2), interpolation=interpolation)(data)
keras_model = keras_mod.models.Model(data, x)
verify_keras_frontend(keras_model)

def test_forward_reshape(self, keras_mod):
"""test_forward_reshape"""
Expand Down