Skip to content

Conversation

@jikechao
Copy link
Member

@jikechao jikechao commented Jun 13, 2023

This PR removed the wrong assertion about UpSampling2D.

In the Keras frontend of TVM, The UpSampling2D has a wired constraint: "Height must equal width for operator Upsample."

However, from the documentation about UpSampling2D, The constraint about size is, " Int, or tuple of 2 integers". Meanwhile, An official example from the Keras documentation uses the size(1, 2)
image.

Thus, the assertion in TVM is wrong. I deleted the related statements and added a bug-triggering test case.

@echuraev @masahi @Hzfengsy

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jun 13, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@jikechao jikechao changed the title Fix UpSampling2D about the wrong assertion about size [Bugfix][Relay][Keras] Fix UpSampling2D about the wrong assertion about size Jun 13, 2023
@echuraev echuraev merged commit 081cc2e into apache:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants