Skip to content

TS-4107: proxy.process.ssl.total_success_handshake_count_in has wrong record type #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jpeach wants to merge 1 commit into from
Closed

TS-4107: proxy.process.ssl.total_success_handshake_count_in has wrong record type #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion iocore/net/SSLUtils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,7 +902,7 @@ SSLInitializeStatistics()
// SSL handshake time
RecRegisterRawStat(ssl_rsb, RECT_PROCESS, "proxy.process.ssl.total_handshake_time", RECD_INT, RECP_PERSISTENT,
(int)ssl_total_handshake_time_stat, RecRawStatSyncSum);
RecRegisterRawStat(ssl_rsb, RECT_PROCESS, "proxy.process.ssl.total_success_handshake_count", RECD_INT, RECP_PERSISTENT,
RecRegisterRawStat(ssl_rsb, RECT_PROCESS, "proxy.process.ssl.total_success_handshake_count_in", RECD_INT, RECP_PERSISTENT,
(int)ssl_total_success_handshake_count_in_stat, RecRawStatSyncCount);
RecRegisterRawStat(ssl_rsb, RECT_PROCESS, "proxy.process.ssl.total_success_handshake_count_out", RECD_INT, RECP_PERSISTENT,
(int)ssl_total_success_handshake_count_out_stat, RecRawStatSyncCount);
Expand Down
2 changes: 1 addition & 1 deletion mgmt/RecordsConfig.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1767,7 +1767,7 @@ static const RecordElement RecordsConfig[] =
,
{RECT_NODE, "proxy.node.log.bytes_lost_before_written_to_disk", RECD_INT, "0", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
,
{RECT_NODE, "proxy.process.ssl.total_success_handshake_count_in", RECD_INT, "0", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
{RECT_PROCESS, "proxy.process.ssl.total_success_handshake_count", RECD_INT, "0", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
,

//#
Expand Down
5 changes: 3 additions & 2 deletions proxy/config/stats.config.xml.default
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1946,11 +1946,12 @@
</expression>
</statistics>

<!-- TS-3409. Mirror proxy.process.ssl.total_success_handshake_count_in for backwards compatibility. -->
<statistics
minimum="0">
<destination>proxy.process.ssl.total_success_handshake_count_in</destination>
<destination>proxy.process.ssl.total_success_handshake_count</destination>
<expression>
proxy.process.ssl.total_success_handshake_count
proxy.process.ssl.total_success_handshake_count_in
</expression>
</statistics>

Expand Down