TS-4107: proxy.process.ssl.total_success_handshake_count_in has wrong record type #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… record type proxy.process.ssl.total_success_handshake_count_in should be the metrics generated in the core SSL code, and the old compatible name proxy.process.ssl.total_success_handshake_count should be generated as a custom metric. The custom metric needs to be registered in RecordsConfig.cc but it should be of type RECT_PROCESS not RECT_NODE.
Contributor
Author
Member
|
Looks good to me. It wasn't clear to me how to do the generated metric when I was originally fixing up the names, so I no doubt messed it up. |
Ftywan
pushed a commit
to Ftywan/trafficserver
that referenced
this pull request
Dec 21, 2022
Use r/w protected pages on top of stacks to guard against stack overflow. The number of VM pages to use for guarding can be set via the config option proxy.config.thread.default.stackguard_pages. Co-authored-by: Mo Chen <uncorrupt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proxy.process.ssl.total_success_handshake_count_inshould be themetrics generated in the core SSL code, and the old compatible name
proxy.process.ssl.total_success_handshake_countshould be generatedas a custom metric. The custom metric needs to be registered in
RecordsConfig.ccbut it should be of typeRECT_PROCESSnotRECT_NODE.