Update TPv2 to Angular 15 #7454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamrickus
added
medium impact
Codecov Report
@@ Coverage Diff @@
## master #7454 +/- ##
============================================
- Coverage 65.45% 65.44% -0.02%
Complexity 98 98
============================================
Files 305 305
Lines 11621 11621
Branches 790 790
============================================
- Hits 7607 7605 -2
- Misses 3667 3669 +2
Partials 347 347
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ocket8888
reviewed
Apr 28, 2023
experimental/traffic-portal/src/app/core/cache-groups/asns/detail/asn-detail.component.scss
Show resolved
Hide resolved
...affic-portal/src/app/core/cache-groups/coordinates/table/coordinates-table.component.spec.ts
Outdated
Show resolved
Hide resolved
ocket8888
added
the
experimental
ocket8888
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates TPv2 to Angular 15, usually these upgrade are pretty "boring" as there aren't many changes but this time is different. In 15, Angular Material went through some significant refactors to more closely align to the Material Design spec (and therefore also makes it more accessible).
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run TPv2 and verify all pages look good at various resolutions. It might also be beneficial to review this PR by commits, the first two commits were just upgrading and automatic migrations. Everything that follows is fixing issues that arose from those migrations or style issues. Also should probably review upgrading recommendations to make sure the changes were done appropriately (and none were missed).
Angular Update guide (great tool in general):
Material Migration guide
PR submission checklist