Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TPv2 Should not use internal Angular Material Selectors #7483

Open
shamrickus opened this issue May 3, 2023 · 0 comments
Open

TPv2 Should not use internal Angular Material Selectors #7483

shamrickus opened this issue May 3, 2023 · 0 comments
Labels
bug something isn't working as intended experimental a feature/component not directly supported by ATC low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one Traffic Portal v2 Related to the experimental Traffic Portal version 2

Comments

@shamrickus
Copy link
Member

This Bug Report affects these Traffic Control components:

  • Traffic Portal v2

Current behavior:

Across the TPv2 code base we currently style Angular Material components by attaching to internal elements/attributes. For instance mat-card or .mat-mdc-card (once #7454 is merged).

Expected behavior:

These instances should be updated to use our own classes as selectors, for instance instead of attaching to a mat-card we should add our own class to it and select for that class. The Angular Material library is built with this in mind so this method of styling.
@shamrickus shamrickus added bug something isn't working as intended low impact affects only a small portion of a CDN, and cannot itself break one low difficulty the estimated level of effort to resolve this issue is low Traffic Portal v2 Related to the experimental Traffic Portal version 2 labels May 3, 2023
@shamrickus shamrickus mentioned this issue May 3, 2023
Merged
4 tasks
@ocket8888 ocket8888 added the experimental a feature/component not directly supported by ATC label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something isn't working as intended experimental a feature/component not directly supported by ATC low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one Traffic Portal v2 Related to the experimental Traffic Portal version 2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shamrickus @ocket8888