THRIFT-5467 Python: fix CannotSendHeader exception #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything I can do to get this merged? |
|
There's some strange message in the logs ... could you force-push to trigger CI again? |
Based on the python source for `http.client`, `HTTPConnection.putheader` can only be called after a request has been started, and before it's been sent. Otherwise it will throw a `http.client.CannotSendHeader` exception. If the server returns a `Set-Cookie` header, the client will always fail with the `CannotSendHeader` exception because `HTTPConnection.putheader` is called after reading the response. With this patch we will call this method before the request has been sent.
csordasmarton
force-pushed
the
fix_python_http_client_save_cookie
branch
from
2f62d38
to
be39e06
Compare
|
@Jens-G Done. I also rebased my branch. |
|
I see in the Jira that this issue is fixed as part of v0.17.0. What are the timelines for to release of this version? |
|
@Jens-G, can we get this released to pypi? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the python source for
http.client,HTTPConnection.putheadercan only be called after a request has been started, and before it's
been sent. Otherwise it will throw a
http.client.CannotSendHeaderexception.
If the server returns a
Set-Cookieheader, the client will alwaysfail with the
CannotSendHeaderexception becauseHTTPConnection.putheaderis called after reading the response.
With this patch we will call this method before the request has been sent.