Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade thrift compiler to 0.15.0 #3450

Open
csordasmarton opened this issue Oct 12, 2021 · 7 comments · May be fixed by #3556
Open

Upgrade thrift compiler to 0.15.0 #3450

csordasmarton opened this issue Oct 12, 2021 · 7 comments · May be fixed by #3556
Labels
dependencies 📦 Pull requests that update a dependency file version 🎉 Version bump/new release. web 🌍 Related to the web app

Comments

@csordasmarton
Copy link
Contributor

Pypi and npm packages are available for thrift 0.15.0 version so we can try to upgrade it:

Unforunately the docker image what we used during development is deprecated and doesn't have an image for this version. So we have to build our own image (codechecker/thrift) based on the following configuration file: https://github.com/ahawkins/docker-thrift/blob/d7e73876549d205898b1922bcbf69e74ef11c288/0.12/Dockerfile

@csordasmarton csordasmarton added the version 🎉 Version bump/new release. label Oct 12, 2021
@csordasmarton csordasmarton added this to the release 6.18.0 milestone Oct 12, 2021
@csordasmarton csordasmarton linked a pull request Dec 14, 2021 that will close this issue
@csordasmarton csordasmarton removed this from the release 6.19.0 milestone Dec 14, 2021
@csordasmarton
Copy link
Contributor Author

There is a bug in the 0.15.0 thrift (Python part) and for now we can't upgrade to this version until it is fixed. For more information see: https://issues.apache.org/jira/projects/THRIFT/issues/THRIFT-5467.

@csordasmarton
Copy link
Contributor Author

I created a patch to solve this problem: apache/thrift#2491

@csordasmarton
Copy link
Contributor Author

Okay, now the patch is merged, but we have to wait the next release (>0.16.0).

@nolange
Copy link

nolange commented Mar 22, 2023

thrift is now on version 0.18.1.

I cant compile codechecker on soon-to-be-reelased debian "bookworm" anymore since the old thrift fails to compile.

@whisperity whisperity added web 🌍 Related to the web app dependencies 📦 Pull requests that update a dependency file labels Mar 22, 2023
@nolange
Copy link

nolange commented Jul 3, 2023

Ping? thrift 0.13.0 belongs into a museum!

@bruntib
Copy link
Contributor

bruntib commented Jul 20, 2023

Hi,

I started to check this upgrade. But may I ask, what workflow does it prevent in Debian? I mean, we have a "make build" target in the "api" directory which uses a docker container to build the Thrift api in a container. What is the motivation of building stubs natively on the host machine?

There is also a second issue: the latest Thrift version is 0.16 on pypi. It seems like it is not maintained, so probably that should be the latest one that we could use.

@nolange
Copy link

nolange commented Jul 20, 2023

Hi,

I started to check this upgrade. But may I ask, what workflow does it prevent in Debian? I mean, we have a "make build" target in the "api" directory which uses a docker container to build the Thrift api in a container. What is the motivation of building stubs natively on the host machine?

I dont know, I did run pip install codechecker and it failed when installing / compiling thrift.
It does work now - so I don't know what was the issue.

There is also a second issue: the latest Thrift version is 0.16 on pypi. It seems like it is not maintained, so probably that should be the latest one that we could use.

The last version of codechecker on pypi is 6.22.1, and not the current release. Does this mean its not maintained?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies 📦 Pull requests that update a dependency file version 🎉 Version bump/new release. web 🌍 Related to the web app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants