-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade thrift compiler to 0.15.0 #3450
Comments
There is a bug in the |
I created a patch to solve this problem: apache/thrift#2491 |
Okay, now the patch is merged, but we have to wait the next release (>0.16.0). |
thrift is now on version 0.18.1. I cant compile codechecker on soon-to-be-reelased debian "bookworm" anymore since the old thrift fails to compile. |
Ping? thrift 0.13.0 belongs into a museum! |
Hi, I started to check this upgrade. But may I ask, what workflow does it prevent in Debian? I mean, we have a "make build" target in the "api" directory which uses a docker container to build the Thrift api in a container. What is the motivation of building stubs natively on the host machine? There is also a second issue: the latest Thrift version is 0.16 on pypi. It seems like it is not maintained, so probably that should be the latest one that we could use. |
I dont know, I did run
The last version of codechecker on pypi is 6.22.1, and not the current release. Does this mean its not maintained? |
Pypi and npm packages are available for thrift 0.15.0 version so we can try to upgrade it:
Unforunately the docker image what we used during development is deprecated and doesn't have an image for this version. So we have to build our own image (
codechecker/thrift
) based on the following configuration file: https://github.com/ahawkins/docker-thrift/blob/d7e73876549d205898b1922bcbf69e74ef11c288/0.12/DockerfileThe text was updated successfully, but these errors were encountered: