Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[version] Upgrade thrift to 0.15.0 #3556

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[version] Upgrade thrift to 0.15.0 #3556

wants to merge 2 commits into from

Conversation

csordasmarton
Copy link
Contributor

Closes #3450

@csordasmarton
[docker] Add docker image to build latest thrift from
4f69f34 
Unforunately the [official docker image](https://hub.docker.com/_/thrift) what
we used during development is deprecated and doesn't have an image for latest
thrift versions. For this reason we will build our own image (`codechecker/thrift`)
based on docker file from
[here](https://github.com/ahawkins/docker-thrift/blob/master/0.12/Dockerfile).
@csordasmarton csordasmarton added documentation 📖 Changes to documentation. version 🎉 Version bump/new release. labels Dec 14, 2021
@csordasmarton csordasmarton added this to the release 6.19.0 milestone Dec 14, 2021
@csordasmarton
[version] Upgrade thrift to 0.15.0
76fcca1 
Upgrade thrift to `0.15.0` and generate new local packages from
thrift files.
@csordasmarton
Copy link
Contributor Author

There is a bug in the 0.15.0 thrift and this is the reason why github actions are failed. For more information see: https://issues.apache.org/jira/projects/THRIFT/issues/THRIFT-5467. For now I think we can't upgrade to this version until this bug is fixed.

@whisperity whisperity added the dependencies 📦 Pull requests that update a dependency file label Dec 15, 2021
@csordasmarton csordasmarton added the WIP 💣 Work In Progress label Dec 21, 2021
@whisperity whisperity added javascript Pull requests that update JavaScript code (used by DependaBot) python Pull requests that update Python code (used by DependaBot) and removed version 🎉 Version bump/new release. labels Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruntib bruntib Awaiting requested review from bruntib bruntib is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dependencies 📦 Pull requests that update a dependency file documentation 📖 Changes to documentation. javascript Pull requests that update JavaScript code (used by DependaBot) python Pull requests that update Python code (used by DependaBot) WIP 💣 Work In Progress
Projects
None yet
Milestone
Future features
Development

Successfully merging this pull request may close these issues.

Upgrade thrift compiler to 0.15.0
2 participants
@csordasmarton @whisperity