-
Notifications
You must be signed in to change notification settings - Fork 113
chore: relocate amber #3878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: relocate amber #3878
Conversation
Signed-off-by: Yicong Huang <17627829+Yicong-Huang@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR relocates the amber engine module from core/amber to the root directory as part of a reorganization plan. This change affects path references throughout the codebase that previously pointed to the amber module within the core directory.
- Moved amber engine from
core/amberto rootamberdirectory - Updated all path references and imports to reflect the new location
- Relocated build and deployment scripts from
core/scriptsto rootbindirectory
Reviewed Changes
Copilot reviewed 6 out of 608 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| amber/src/main/python/core/storage/iceberg/test_iceberg_document.py | Updated directory path to reflect amber's new location |
| access-control-service/src/main/scala/org/apache/texera/service/AccessControlService.scala | Replaced import with direct path construction and added required import |
| Dockerfile | Updated script paths to point to relocated bin directory |
| CONTRIBUTING.md | Updated documentation paths for amber engine location |
| .github/workflows/github-action-build.yml | Updated CI workflow paths for relocated directories |
| .github/labeler.yml | Updated GitHub labeler configuration for new directory structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Yicong Huang <17627829+Yicong-Huang@users.noreply.github.com>
# Conflicts: # bin/python-proto-gen.sh
According to the reorganization plan #3846. This PR moves
core/amberout to root.resolves #3865