Skip to content

Conversation

@Yicong-Huang
Copy link
Contributor

According to the reorganization plan #3846. This PR moves core/amber out to root.

resolves #3865

Copilot AI review requested due to automatic review settings October 12, 2025 17:22
@github-actions github-actions bot added dependencies Pull requests that update a dependency file ddl-change Changes to the TexeraDB DDL python frontend Changes related to the frontend GUI ci changes related to CI docs Changes related to documentations backend Anything related to backend services build service labels Oct 12, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR relocates the amber engine module from core/amber to the root directory as part of a reorganization plan. This change affects path references throughout the codebase that previously pointed to the amber module within the core directory.

  • Moved amber engine from core/amber to root amber directory
  • Updated all path references and imports to reflect the new location
  • Relocated build and deployment scripts from core/scripts to root bin directory

Reviewed Changes

Copilot reviewed 6 out of 608 changed files in this pull request and generated no comments.

Show a summary per file
File Description
amber/src/main/python/core/storage/iceberg/test_iceberg_document.py Updated directory path to reflect amber's new location
access-control-service/src/main/scala/org/apache/texera/service/AccessControlService.scala Replaced import with direct path construction and added required import
Dockerfile Updated script paths to point to relocated bin directory
CONTRIBUTING.md Updated documentation paths for amber engine location
.github/workflows/github-action-build.yml Updated CI workflow paths for relocated directories
.github/labeler.yml Updated GitHub labeler configuration for new directory structure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Yicong-Huang Yicong-Huang changed the base branch from main to chore/rename-core-scripts-to-bin October 12, 2025 17:23
Signed-off-by: Yicong Huang <17627829+Yicong-Huang@users.noreply.github.com>
@Yicong-Huang Yicong-Huang removed dependencies Pull requests that update a dependency file frontend Changes related to the frontend GUI docs Changes related to documentations service labels Oct 12, 2025
@github-actions github-actions bot added dependencies Pull requests that update a dependency file frontend Changes related to the frontend GUI docs Changes related to documentations service labels Oct 12, 2025
Base automatically changed from chore/rename-core-scripts-to-bin to main October 12, 2025 18:29
@Yicong-Huang Yicong-Huang removed dependencies Pull requests that update a dependency file frontend Changes related to the frontend GUI docs Changes related to documentations labels Oct 12, 2025
@github-actions github-actions bot added dependencies Pull requests that update a dependency file frontend Changes related to the frontend GUI docs Changes related to documentations labels Oct 12, 2025
@Yicong-Huang Yicong-Huang removed dependencies Pull requests that update a dependency file frontend Changes related to the frontend GUI docs Changes related to documentations labels Oct 12, 2025
@github-actions github-actions bot added dependencies Pull requests that update a dependency file frontend Changes related to the frontend GUI docs Changes related to documentations labels Oct 12, 2025
@Yicong-Huang Yicong-Huang merged commit 95f1bb1 into main Oct 12, 2025
18 of 19 checks passed
@Yicong-Huang Yicong-Huang deleted the chore/relocate-amber branch October 12, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Anything related to backend services build ci changes related to CI dependencies Pull requests that update a dependency file docs Changes related to documentations frontend Changes related to the frontend GUI python service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

move core/amber to amber

2 participants