build(amber): rename Amber artifact #3518
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yicong-Huang
changed the title
Yicong-Huang
changed the title
Contributor
|
I will wait for #3516 to be merged, update this PR a bit, and approve |
Yicong-Huang
force-pushed
the
yicong-modify-artifact-version-1.0.0
branch
from
5d5f1b6 to
75a5145
Compare
Contributor
Author
|
@bobbai00 please go ahead update it. |
Yicong-Huang
changed the title
Signed-off-by: Yicong Huang <17627829+Yicong-Huang@users.noreply.github.com>
Yicong-Huang
changed the title
Yicong-Huang
changed the title
Contributor
Author
|
@bobbai00 can I merge this PR? |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames the Amber artifact from "texera" to "amber" to ensure consistent naming across the codebase.
- Updated the artifact name in the SBT build configuration from "texera" to "amber"
- Modified shell scripts to reference the new "amber-" artifact paths instead of "texera-"
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/amber/build.sbt | Changed the SBT project name from "texera" to "amber" |
| core/scripts/build-services.sh | Updated unzip and rm commands to use amber-* artifact paths |
| core/scripts/workflow-computing-unit.sh | Updated computing unit master binary paths to use amber-* directory |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
closed as we have done it in #3878. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The amber artifact has been named as "texera". This PR changes it to "amber".