Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flags to control query sharing, KV exposure #9120

Merged
merged 11 commits into from
Feb 19, 2020
+161 −41
Merged

Add feature flags to control query sharing, KV exposure #9120

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
adbe239
Add feature flags to control query sharing, KV exposure
Feb 11, 2020
2b4d1c9
Add tests, fix bug
Feb 11, 2020
11bded6
Skip test for kv endpoints when they are disabled
Feb 11, 2020
d097f7b
ESLint fixes
Feb 12, 2020
e7b3c70
Remove unnecessary binds
Feb 12, 2020
f1e683b
Fix eslint errors
Feb 12, 2020
52585c2
Add note to UPDATING.md RE: new feature flag options
Feb 13, 2020
ea37902
Use expanded version of RBAC
Feb 14, 2020
e5c7adf
Enable KV_STORE and SHARE_QUERIES_VIA_KV_STORE feature flags in the t…
Feb 18, 2020
3163318
Merge branch 'master' into wbarrett/disable-kv-store-sharing
Feb 18, 2020
dbe24cb
Fix black
Feb 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix eslint errors
  • Loading branch information
Will Barrett committed Feb 12, 2020
commit f1e683b7634df0e4a7ed0e51b70d9a795924a726
4 changes: 2 additions & 2 deletions superset-frontend/src/SqlLab/components/ShareSqlLabQuery.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ import React from 'react';
import PropTypes from 'prop-types';
import { Popover, OverlayTrigger } from 'react-bootstrap';
import { t } from '@superset-ui/translation';
import { isFeatureEnabled, FeatureFlag } from 'src/featureFlags';

import Button from '../../components/Button';
import CopyToClipboard from '../../components/CopyToClipboard';
import { storeQuery } from '../../utils/common';
import getClientErrorObject from '../../utils/getClientErrorObject';
import withToasts from '../../messageToasts/enhancers/withToasts';
import { isFeatureEnabled, FeatureFlag } from 'src/featureFlags';

const propTypes = {
queryEditor: PropTypes.shape({
Expand Down Expand Up @@ -54,7 +54,7 @@ class ShareSqlLabQuery extends React.Component {
return this.getCopyUrlForKvStore();
}

this.getCopyUrlForSavedQuery();
return this.getCopyUrlForSavedQuery();
}

getCopyUrlForKvStore() {
Expand Down