Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flags to control query sharing, KV exposure #9120

Merged
merged 11 commits into from
Feb 19, 2020
Merged

Add feature flags to control query sharing, KV exposure #9120

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
adbe239
Add feature flags to control query sharing, KV exposure
Feb 11, 2020
2b4d1c9
Add tests, fix bug
Feb 11, 2020
11bded6
Skip test for kv endpoints when they are disabled
Feb 11, 2020
d097f7b
ESLint fixes
Feb 12, 2020
e7b3c70
Remove unnecessary binds
Feb 12, 2020
f1e683b
Fix eslint errors
Feb 12, 2020
52585c2
Add note to UPDATING.md RE: new feature flag options
Feb 13, 2020
ea37902
Use expanded version of RBAC
Feb 14, 2020
e5c7adf
Enable KV_STORE and SHARE_QUERIES_VIA_KV_STORE feature flags in the t…
Feb 18, 2020
3163318
Merge branch 'master' into wbarrett/disable-kv-store-sharing
Feb 18, 2020
dbe24cb
Fix black
Feb 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use expanded version of RBAC
  • Loading branch information
Will Barrett committed Feb 14, 2020
commit ea37902f61a7aef3b03cc88ca02c246c71f79efd
2 changes: 1 addition & 1 deletion UPDATING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ assists people when migrating to a new version.
* [9120](https://github.com/apache/incubator-superset/pull/9120): Changes the default behavior of ad-hoc sharing of
queries in SQLLab to one that links to the saved query rather than one that copies the query data into the KVStore
model and links to the record there. This is a security-related change that makes SQLLab query
sharing respect the existing RBAC. Should you wish to retain the existing behavior, set two feature flags:
sharing respect the existing role-based access controls. Should you wish to retain the existing behavior, set two feature flags:
`"KV_STORE": True` will re-enable the `/kv/` and `/kv/store/` endpoints, and `"SHARE_QUERIES_VIA_KV_STORE": True`
will tell the front-end to utilize them for query sharing.
* [9046](https://github.com/apache/incubator-superset/pull/9046): Replaces `can_only_access_owned_queries` by
Expand Down