Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(accessibility): logo outline on tab navigation, but not on click #30077

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix(accessibility): logo outline on tab navigation, but not on click #30077

merged 1 commit into from
Sep 3, 2024

Conversation

rusackas
Copy link
Member

SUMMARY

Fixes #30054

Overrides bootstrap's focus style to hide the outline, and adds focus-visible which works for keyboard navigation. Also disable the disabling of keyboard navigation, so you can actually navigate to it by keyboard.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas requested a review from eschutho August 30, 2024 20:34
@dosubot dosubot bot added the design:accessibility Related to accessibility standards label Aug 30, 2024
@michael-s-molina
Copy link
Member

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

@michael-s-molina Ephemeral environment spinning up at http://54.149.158.203:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas rusackas merged commit 9c3eb8f into master Sep 3, 2024
36 of 37 checks passed
@rusackas rusackas deleted the Fixing-logo-accessibility branch September 3, 2024 18:04
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Ephemeral environment shutdown and build artifacts deleted.

@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Sep 3, 2024
sadpandajoe pushed a commit that referenced this pull request Sep 3, 2024
@rusackas @sadpandajoe
fix(accessibility): logo outline on tab navigation, but not on click (#…
45da3f4 
…30077)

(cherry picked from commit 9c3eb8f)
@github-actions github-actions bot added 🍒 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@eschutho eschutho Awaiting requested review from eschutho

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels design:accessibility Related to accessibility standards size/S v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird focus indicator on navigation header
3 participants
@rusackas @michael-s-molina @sadpandajoe