Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird focus indicator on navigation header #30054

Closed
3 tasks done
michael-s-molina opened this issue Aug 29, 2024 · 1 comment · Fixed by #30077
Closed
3 tasks done

Weird focus indicator on navigation header #30054

michael-s-molina opened this issue Aug 29, 2024 · 1 comment · Fixed by #30077
Labels
design:accessibility Related to accessibility standards

Comments

@michael-s-molina
Copy link
Member

Bug description

Superset is showing a weird focus indicator on the navigation header. I'm not sure if this was intended for accessibility but it gets activated only if you click on the Superset logo. If you click on Dashboard, it will not activate the focus.

How to reproduce the bug

  1. Click on the Superset logo
  2. Use tab to navigate to other menu option
  3. Check that if you click on Dashboard the focus is not activated

Screenshots/recordings

Screen.Recording.2024-08-29.at.11.38.46.mov

Superset version

master / latest-dev

Python version

3.9

Node version

16

Browser

Chrome

Additional context

Also present in 4.1.0 RC2

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
@dosubot dosubot bot added the design:accessibility Related to accessibility standards label Aug 29, 2024
@rusackas
Copy link
Member

Looks like it's coming from bootstrap, which got bumped recently. I reckon I can fix this pretty quick (famous last words).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design:accessibility Related to accessibility standards
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants